packaging/aix: declare bos.perf.libperfstat as installp prerequisite#50391
Conversation
github-actions
Bot
added
the
short review
pgimalac
added
changelog/no-changelog
Files inventory check summaryFile checks results against ancestor 80c7de40: Results for datadog-agent_7.80.0~devel.git.488.b52ca29.pipeline.111707602-1_amd64.deb:No change detected |
pgimalac
force-pushed
the
pgimalac/aix-libperfstat-prereq
branch
from
b2e3bb9 to
6e4ca6a
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e4ca6a61e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
libperfstat is a startup-time dynamic dependency of the agent binary and trace-agent. Without it they fail to load entirely. Declaring it as a prereq causes installp to fail early with a clear message rather than crashing at runtime with a cryptic loader error.
pgimalac
force-pushed
the
pgimalac/aix-libperfstat-prereq
branch
from
6e4ca6a to
b52ca29
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
pgimalac/aix-libperfstat-prereq
branch
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ed51e26 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.58 | [-1.43, +4.58] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.58 | [-1.43, +4.58] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.68 | [+0.57, +0.79] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.48 | [+0.23, +0.72] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.38 | [+0.19, +0.58] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.17 | [+0.02, +0.33] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.12 | [+0.03, +0.22] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.08 | [+0.04, +0.12] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.42, +0.43] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.19, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.15, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.44, +0.40] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.05 | [-1.00, +0.91] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.05 | [-0.60, +0.50] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.12 | [-0.18, -0.07] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.17 | [-0.37, +0.03] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.18 | [-0.23, -0.13] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.21 | [-0.44, +0.03] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.29 | [-0.33, -0.24] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.30 | [-0.46, -0.14] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.31 | [-0.38, -0.24] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.33 | [-1.52, -1.13] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 666 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 241.69MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 704 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.16GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 141.88MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 471.44MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 173.01MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 358.56 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 362.69MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
2 participants
What does this PR do?
Adds
*prereq bos.perf.libperfstat 7.1.0.0to the installpRequisites:field ingen.template.in.Motivation
libperfstat.a(shr_64.o)is a startup-time dynamic dependency of the agent binary and trace-agent. If absent, neither binary loads and the agent fails completely with a cryptic0509-022 Cannot load moduleerror. Declaring it as a prerequisite causesinstallpto fail at install time with a clear message instead.bos.perf.libperfstatis part of the AIX base OS and is present on all non-stripped installs, so this prerequisite is a no-op on standard systems — it only triggers on minimal installs where the fileset was explicitly removed.Describe how you validated your changes
Rebuilding the BFF and confirming
installp -lshows the requisite, and that installation still works on the 7.2 host.Additional Notes
N/A